jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin
https://plugins.jenkins.io/cloudbees-bitbucket-branch-source
MIT License
217 stars 349 forks source link

Change backoff strategy to exponential for BitbucketCloudApiClient when rate-limited #841

Open thomas-boehm-tractive opened 3 months ago

thomas-boehm-tractive commented 3 months ago

Change backoff strategy to exponential for BitbucketCloudApiClient when rate-limited, as a fixed wait time of 5 seconds sends too many unnecessary requests that can be avoided.

Your checklist for this pull request

Fixes #840

nfalco79 commented 3 months ago

This PR is already covered by the #414 that have a long discussion. There is also consideration in issue #831 and https://issues.jenkins.io/browse/JENKINS-64418

thomas-boehm-tractive commented 1 month ago

This PR is already covered by the https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/414 that have a long discussion. There is also consideration in issue https://github.com/jenkinsci/bitbucket-branch-source-plugin/issues/831 and https://issues.jenkins.io/browse/JENKINS-64418

@nfalco79 does that mean I sould close this PR?

nfalco79 commented 1 month ago

PRs should refer to an issue with the reason of changes, in this cases there is one with details. For what I see other PR has an ongoing review with the old-old maintainers but was stucks. What I mean is that this PR should takes in consideration those changes, comments and the JIRA issue to completed.