search

jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin
https://plugins.jenkins.io/cloudbees-bitbucket-branch-source
MIT License
217 stars 349 forks source link

Fix "eating of exception" introduced in PR #839 #850

Open thomas-boehm-tractive opened 1 month ago

thomas-boehm-tractive commented 1 month ago

Jenkins and plugins versions report

Environment ```text Jenkins: 2.387.3 OS: Linux - 4.14.336-257.568.amzn2.x86_64 Java: 11.0.19 - Eclipse Adoptium (OpenJDK 64-Bit Server VM) ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Controller running in docker

Reproduction steps

https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/839 introduced the issue that exceptions of the callable are no longer forwarded, but "eaten" by a try-catch block.

Expected Results

Exceptions should be thrown, as before.

Actual Results

null is returned -> no exception thrown and logged

Anything else?

No response

Are you interested in contributing a fix?

A PR will be created and linked.

thomas-boehm-tractive commented 1 month ago

Related to ticket https://github.com/jenkinsci/bitbucket-branch-source-plugin/issues/838, where this bug was introduced.

thomas-boehm-tractive commented 1 month ago

Issue was discussed here: https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/839#pullrequestreview-1976010981