Fix removal of exception throwing in BitbucketCloudApiClient.java

thomas-boehm-tractive commented 1 month ago

Bug was introduced in https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/839, as discussed here https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/839#pullrequestreview-1976010981

In order to log the exceptions, they have to be thrown. In the previous PR, all exceptions were caught by a catch block, and null was returned. This is not the behavior from the before the PR.

Your checklist for this pull request

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or in Jenkins JIRA
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Did you provide a test-case? That demonstrates feature works or fixes the issue.

Fixes #850

nfalco79 commented 1 month ago

sound good

nfalco79 commented 2 weeks ago

@thomas-boehm-tractive please have a look to be able to merge this fix

thomas-boehm-tractive commented 1 week ago

@thomas-boehm-tractive please have a look to be able to merge this fix

@nfalco79 have a look at what? I don't see any issues with this PR (checks succeeded, no conflicts with base branch...), what is missing in your opinion, or do you see anything I am missing?

jenkinsci / bitbucket-branch-source-plugin

Fix removal of exception throwing in BitbucketCloudApiClient.java #851

Your checklist for this pull request