Branch Scan will always return "Changes detected: master (null → 469e391aa938e772825b97b85008954820c840bc)"

thomasleber commented 4 weeks ago

Jenkins and plugins versions report

Environment

```text Jenkins: 2.462.3 OS: Linux - 5.15.0-1071-aws Java: 17.0.13 - Amazon.com Inc. (OpenJDK 64-Bit Server VM) --- analysis-model-api:12.9.0 antisamy-markup-formatter:162.v0e6ec0fcfcf6 apache-httpcomponents-client-4-api:4.5.14-208.v438351942757 apache-httpcomponents-client-5-api:5.4-124.v31e2987e48f4 asm-api:9.7.1-97.v4cc844130d97 audit-trail:382.vf64d6f626060 authentication-tokens:1.119.v50285141b_7e1 aws-java-sdk-minimal:1.12.772-474.v7f79a_2046a_fb_ aws-java-sdk-secretsmanager:1.12.772-474.v7f79a_2046a_fb_ aws-secrets-manager-credentials-provider:1.214.va_0a_d8268d068 aws-secrets-manager-secret-source:1.72.v61781b_35c542 basic-branch-build-strategies:81.v05e333931c7d blueocean:1.27.16 blueocean-bitbucket-pipeline:1.27.16 blueocean-commons:1.27.16 blueocean-config:1.27.16 blueocean-core-js:1.27.16 blueocean-dashboard:1.27.16 blueocean-display-url:2.4.3 blueocean-events:1.27.16 blueocean-git-pipeline:1.27.16 blueocean-github-pipeline:1.27.16 blueocean-i18n:1.27.16 blueocean-jwt:1.27.16 blueocean-personalization:1.27.16 blueocean-pipeline-api-impl:1.27.16 blueocean-pipeline-editor:1.27.16 blueocean-pipeline-scm-api:1.27.16 blueocean-rest:1.27.16 blueocean-rest-impl:1.27.16 blueocean-web:1.27.16 bootstrap5-api:5.3.3-1 bouncycastle-api:2.30.1.78.1-248.ve27176eb_46cb_ branch-api:2.1182.va_e67548fb_ed2 build-blocker-plugin:166.vc82fc20b_a_ed6 build-timeout:1.33 build-with-parameters:76.v9382db_f78962 caffeine-api:3.1.8-133.v17b_1ff2e0599 checks-api:2.2.1 chucknorris:159.vdfe649cb_9c37 cloudbees-bitbucket-branch-source:888.v8e6d479a_1730 cloudbees-folder:6.955.v81e2a_35c08d3 commons-compress-api:1.26.1-2 commons-httpclient3-api:3.1-3 commons-lang3-api:3.17.0-84.vb_b_938040b_078 commons-text-api:1.12.0-129.v99a_50df237f7 configuration-as-code:1850.va_a_8c31d3158b_ copyartifact:757.v05365583a_455 coverage:1.16.1 credentials:1384.vf0a_2ed06f9c6 credentials-binding:681.vf91669a_32e45 crowd2:4.4.0 dark-theme:479.v661b_1b_911c01 data-tables-api:2.1.8-1 display-url-api:2.204.vf6fddd8a_8b_e9 docker-commons:443.v921729d5611d docker-workflow:580.vc0c340686b_54 durable-task:577.v2a_8a_4b_7c0247 echarts-api:5.5.1-3 eddsa-api:0.3.0-4.v84c6f0f4969e email-ext:1844.v3ea_a_b_842374a_ favorite:2.221.v19ca_666b_62f5 file-operations:321.vd98ef0161b_7e font-awesome-api:6.6.0-2 forensics-api:2.6.0 generic-webhook-trigger:2.2.5 git:5.5.2 git-client:5.0.0 git-forensics:2.2.1 github:1.40.0 github-api:1.321-468.v6a_9f5f2d5a_7e github-branch-source:1807.v50351eb_7dd13 gson-api:2.11.0-85.v1f4e87273c33 handy-uri-templates-2-api:2.1.8-30.v7e777411b_148 htmlpublisher:1.36 http_request:1.19 instance-identity:201.vd2a_b_5a_468a_a_6 ionicons-api:74.v93d5eb_813d5f jackson2-api:2.17.0-379.v02de8ec9f64c jakarta-activation-api:2.1.3-1 jakarta-mail-api:2.1.3-1 javax-activation-api:1.2.0-7 javax-mail-api:1.6.2-10 jaxb:2.3.9-1 jenkins-design-language:1.27.16 jersey2-api:2.44-151.v6df377fff741 jira:3.13 jjwt-api:0.11.5-112.ve82dfb_224b_a_d jobConfigHistory:1277.vb_9a_0808495d7 joda-time-api:2.13.0-93.v9934da_29b_a_e9 jquery3-api:3.7.1-2 json-api:20240303-101.v7a_8666713110 json-path-api:2.9.0-118.v7f23ed82a_8b_8 junit:1307.vdd5b_2646279e ldap:725.v3cb_b_711b_1a_ef lockable-resources:1320.v1f0dff578476 login-theme:238.va_647346d317b_ mailer:488.v0c9639c1a_eb_3 matrix-auth:3.2.3 matrix-project:839.vff91cd7e3a_b_2 metrics:4.2.21-458.vcf496cb_839e4 mina-sshd-api-common:2.14.0-133.vcc091215a_358 mina-sshd-api-core:2.14.0-133.vcc091215a_358 multibranch-scan-webhook-trigger:1.0.11 nexus-artifact-uploader:2.14 okhttp-api:4.11.0-172.vda_da_1feeb_c6e parameter-separator:250.va_6292fd7f47b_ pipeline-build-step:540.vb_e8849e1a_b_d8 pipeline-graph-analysis:216.vfd8b_ece330ca_ pipeline-graph-view:340.v28cecee8b_25f pipeline-groovy-lib:744.v5b_556ee7c253 pipeline-input-step:495.ve9c153f6067b_ pipeline-milestone-step:119.vdfdc43fc3b_9a_ pipeline-model-api:2.2214.vb_b_34b_2ea_9b_83 pipeline-model-definition:2.2214.vb_b_34b_2ea_9b_83 pipeline-model-extensions:2.2214.vb_b_34b_2ea_9b_83 pipeline-rest-api:2.34 pipeline-stage-step:312.v8cd10304c27a_ pipeline-stage-tags-metadata:2.2214.vb_b_34b_2ea_9b_83 pipeline-utility-steps:2.18.0 plain-credentials:183.va_de8f1dd5a_2b_ plugin-usage-plugin:4.6 plugin-util-api:5.1.0 prism-api:1.29.0-17 prometheus:787.v52e8f47488fc pubsub-light:1.18 rebuild:332.va_1ee476d8f6d resource-disposer:0.24 role-strategy:743.v142ea_b_d5f1d3 saferestart:0.7 scm-api:696.v778d637b_a_762 script-security:1365.v4778ca_84b_de5 simple-theme-plugin:196.v96d9592f4efa_ snakeyaml-api:2.3-123.v13484c65210a_ spotinst:2.2.18 sse-gateway:1.27 ssh-agent:376.v8933585c69d3 ssh-credentials:343.v884f71d78167 ssh-slaves:2.973.v0fa_8c0dea_f9f sshd:3.330.vc866a_8389b_58 structs:338.v848422169819 theme-manager:262.vc57ee4a_eda_5d timestamper:1.27 token-macro:400.v35420b_922dcb_ trilead-api:2.147.vb_73cc728a_32e variant:60.v7290fc0eb_b_cd warnings-ng:11.10.0 workflow-aggregator:600.vb_57cdd26fdd7 workflow-api:1336.vee415d95c521 workflow-basic-steps:1058.vcb_fc1e3a_21a_9 workflow-cps:3975.v567e2a_1ffa_22 workflow-durable-task-step:1371.vb_7cec8f3b_95e workflow-job:1436.vfa_244484591f workflow-multibranch:795.ve0cb_1f45ca_9a_ workflow-scm-step:427.v4ca_6512e7df1 workflow-step-api:678.v3ee58b_469476 workflow-support:930.vf51d22b_ce488 ws-cleanup:0.47 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Both Linux systems

Reproduction steps

Start Branch Indexing
Check Log

Expected Results

Branches already discovered and maybe even build are not detected as 'changed'

Actual Results

All branches in our system are detected as changed:

Changes detected: <cut branch name> (null → 6337785545608b32642f1cae7e6e10af04d3c4e1)
Did not schedule build for branch: <cut branch name>
Checking branch <cut branch name> from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria
Changes detected: <cut branch name> (null → 6e8e43d3ddbe00556257ad3e077cb968e60554a5)
Did not schedule build for branch: <cut branch name>
Checking branch <cut branch name> from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria
Changes detected: <cut branch name> (null → b7e8f8788ef05923f9ffd23453e501f546ed2494)
Did not schedule build for branch: <cut branch name>
Checking branch <cut branch name> from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria
Changes detected: <cut branch name> (null → 5e73d4f78bd0ee9dbab0dc82039699150ecafc67)
Did not schedule build for branch: <cut branch name>
Checking branch master from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria
Changes detected: master (null → 469e391aa938e772825b97b85008954820c840bc)
Did not schedule build for branch: master
Checking branch <cut branch name> from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria
Changes detected: <cut branch name> (null → da34d3ba5b0f7cf15ec3117bb431035275f732f0)
Did not schedule build for branch: <cut branch name>
Checking branch <cut branch name> from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria
Changes detected: <cut branch name> (null → 402235fcd56273a4a1dd044ea643f6510b83e5cd)
Did not schedule build for branch: <cut branch name>
Checking branch <cut branch name> from <cut repo name>
      ‘infrastructure/pipelines/buildAndTest.groovy’ found
    Met criteria

Anything else?

No response

Are you interested in contributing a fix?

If i can

nfalco79 commented 6 days ago

Has branches ever built? I get null -> only when the job has not be built so the last associated commit is null. That's why it is recognized as changed

thomasleber commented 2 days ago

Yes, some of them have been build. But this "null -> ..." is on all branches and pull requests.

nfalco79 commented 2 days ago

The issue happens when in the job folder miss the scm-revision-hash.xml file

thomasleber commented 2 days ago

ok, that narrows it down. Let me check if this file is missing.

thomasleber commented 1 day ago

We do have this file in some pipelines, but we noticed that it will only be there if the automatic build scheduling is active.

jenkinsci / bitbucket-branch-source-plugin