search

jenkinsci / bitbucket-push-and-pull-request-plugin

Plugin for Jenkins v2.138.2 or later, that triggers job builds on Bitbucket's push and pull request events.
https://plugins.jenkins.io/bitbucket-push-and-pull-request
MIT License
46 stars 50 forks source link

Use "get" prefix for configuration attribute getters #328

Closed laudrup closed 3 months ago

laudrup commented 3 months ago

The configuration-as-code plugin expects a plugins configuration attributes to be accessible with setters prefixed with "set" and getters prefixed with "get" or "is".

Change and add the getters for the configurations attributes that don't follow this convention so this plugin can be fully configured with configuration as code.

A test has been added that ensures that all configuration methods with a "set" prefix has a corresponding "get" or "is" prefix. This is similar to how the configuration as code plugin does it.

I have not created a related issue for this, but the issue is that this plugin is not fully configurable with configuration-as-code which is unfortunate. I will of course create a related issue if this is required.

- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
laudrup commented 3 months ago

Turns out an issue was already created for this. This commit fixes #321