search

jenkinsci / bom

Define plugin dependencies via BOM
https://jenkins.io/doc/developer/plugin-development/dependency-management/#jenkins-plugin-bom
49 stars 52 forks source link

Remove Lockable Resources workaround #3066

Closed basil closed 6 months ago

basil commented 7 months ago

3031 temporarily excluded two tests pending the fix for https://github.com/jenkinsci/lockable-resources-plugin/issues/634. When a new version of Lockable Resource is released with fixes for Data Tables 2.x, these temporary test exclusions should be removed.

mPokornyETM commented 7 months ago

will be fine, when somebody check the changes here https://github.com/jenkinsci/lockable-resources-plugin/issues/634

thx

basil commented 6 months ago

Thanks @mPokornyETM! Any chance we could get a backport to 2.426.x? The test is now passing on the latest line, but still failing on the 2.426.x and earlier lines, because on those lines Data Tables is upgraded, but Lockable Resources is still pinned to the old version without the fix you just released.

Instructions here: https://gist.github.com/jglick/86a30894446ed38f918050c1180483e2

If the answer is "No", that is completely understandable and no problem at all. We will then have to leave this ticket open, with the workaround in place, for the next 6 months or so until this repository drops support for the 2.426.x line, at which point the workaround can be removed and this ticket can then be closed.

mPokornyETM commented 6 months ago

Interesting. I have no idea why it fails. I will check it, but I thnik, I does not have time for next few mounts. Therefore it make also no sense. sry

basil commented 6 months ago

I have no idea why it fails

I do—because on that LTS line, the latest available version of Data Tables is 2.x, which contains a breaking change, while the latest version of Lockable Resources is 1245.vb_05f8a4e28db, which does not contain the adaptation to that breaking change. The first version of Lockable Resources that contains the adaptation is 1255.vf48745da_35d0, but that version requires Jenkins 2.440.1 or later. So it is possible for a user running the 2.426.x or earlier lines to legitimately upgrade all their plugins to the latest supported versions and wind up with an incompatible configuration.

The solution to the problem, if you are interested, is as described in https://github.com/jenkinsci/bom/issues/3066#issuecomment-2080234651: to backport https://github.com/jenkinsci/lockable-resources-plugin/pull/642 to the 2.426.x line following the instructions in https://gist.github.com/jglick/86a30894446ed38f918050c1180483e2. That would not only fix the problem for end users, but it would also allow this ticket to be closed.

basil commented 6 months ago

Thinking about this some more, I suppose another alternative would be to downgrade Data Tables on the 2.426.x line to 1.x, which would be equivalent to the user scenario of rejecting the upgrade due to its incompatibility with Lockable Resources. That could be a good compromise.

basil commented 6 months ago

I have backported the changes to the 2.426.x line in https://github.com/jenkinsci/lockable-resources-plugin/pull/653