jenkinsci / bom

Define plugin dependencies via BOM
https://jenkins.io/doc/developer/plugin-development/dependency-management/#jenkins-plugin-bom
49 stars 52 forks source link

Add Promoted Builds to the managed set #3502

Closed MarkEWaite closed 2 months ago

MarkEWaite commented 2 months ago

Add promoted builds to managed set

Fixes https://github.com/jenkinsci/bom/issues/3171

Testing done

Confirmed that tha tests previously failing with promoted builds are now passing.

Plugin tests that were checked include:

Submitter checklist

MarkEWaite commented 2 months ago

hudson.plugins.promoted_builds.PromotedBuildRebuildParameterProviderTest#testRebuild is incompatible with jenkinsci/rebuild-plugin#155.

Thanks! I've submitted a pull request that proposes a fix by using a different technique in the test to start that build. Pull request is:

If that technique is acceptable, I can merge that pull request and then use that as the version in this pull request.