search

jenkinsci / bom

Define plugin dependencies via BOM
https://jenkins.io/doc/developer/plugin-development/dependency-management/#jenkins-plugin-bom
49 stars 52 forks source link

Extraneous `licenses.xml` entries in plugins with CasC dependency #3819

Open daniel-beck opened 2 weeks ago

daniel-beck commented 2 weeks ago

Jenkins and plugins versions report

Discovered during the release of matrix-auth 3.2.3 which updated the BOM version.

Updating the BOM dependency to 2483.v3b22f030990a or newer added a bunch of bogus license entries in the plugin's about page (target/<artifactid>/META-INF/licenses.xml). I bisected this to #2539.

The following repo contains the pom.xml for a "hello world" plugin in a few "good" and "bad" states: https://github.com/daniel-beck/bom-2539-casc-1714

In my local testing it wasn't as simple as having the CasC dependency (only), without the test dependencies it didn't happen. So I'm filing this here.

What Operating System are you using (both controller, and any agents involved in the problem)?

n/a

Reproduction steps

See above

Expected Results

Image

Actual Results

Image

Anything else?

No response

Are you interested in contributing a fix?

No response

daniel-beck commented 2 weeks ago

FTR this still occurs with

        <artifactId>bom-2.452.x</artifactId>
        <version>3532.v8059503f6b_23</version>