Closed strangelookingnerd closed 2 months ago
In this particular instance it’s about not hard-coding the Java version that is used during the build. The template this action relies on defines its own default which is sufficient most of the time.
You could compare it to overriding the java.version
property in your pom.xml
: The property is already defined in the parent pom file / plugin bom. A plugin rarely has the need to change this value on its own but will get the change automatically in case Jenkins will require a newer version of Java - like it will be the case soon.
In most cases this approach will reduce the cost of maintenance in the long run.
In order to unify the actions configuration this PR will
java-version
in order to rely on the defaultjava-cache
configuration to speed-up the actions buld timepermissions
allowing the action to create security issuesbranches
Please note this PR was created semi-automatically. If you find any issue with it, don't hesitate to ping me. See discussion in https://github.com/jenkinsci/asm-api-plugin/pull/36
Testing done
Awaiting run of the action to verify the changes...
Submitter checklist