jenkinsci / build-name-setter-plugin

Build Name Setter Plugin for Jenkins CI
https://plugins.jenkins.io/build-name-setter/
MIT License
34 stars 51 forks source link

Modernize to latest versions supported by Java 8 #76

Closed sghill-rewrite closed 1 year ago

sghill-rewrite commented 1 year ago

Hi!

This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further or #73 can be rebased.

This PR was generated with an OpenRewrite recipe on Moderne.io.

Testing done

Ran mvn clean verify. I manually updated a test because the default node changed to built-in starting with LTS 2.319.1.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
sghill-rewrite commented 1 year ago

@damianszczepanik I'm not quite sure why the appveyor build is failing with this message.

[ERROR] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
3.8.1 required to no longer download dependencies via HTTP (use HTTPS instead).

It looks like the pom is only using https for repositories to me. The Jenkins checks all passed :tada: