search

jenkinsci / build-name-setter-plugin

Build Name Setter Plugin for Jenkins CI
https://plugins.jenkins.io/build-name-setter/
MIT License
34 stars 51 forks source link

Build on AppVeyor with Java 17 #81

Closed sghill closed 1 year ago

sghill commented 1 year ago

This change expands on #79 by defining JAVA_HOME to JDK 17, which is required for #77. JDK 11 is not available in the new Visual Studio 2022 image.

Testing done

JDK 17 builds are already passing in Jenkinsfile on Linux.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
damianszczepanik commented 1 year ago

Did you try to switch to "Visual Studio 2019" that has this JDK installed?

sghill commented 1 year ago

I didn't try the Visual Studio 2019 image. I wasn't sure going to an older image for JDK 11 would have much value since JDK 17 will likely be the minimum version fairly soon anyway.

hervelemeur commented 1 year ago

@sghill out of curiosity and for my personal culture, what AppVeyor is used for here?

sghill commented 1 year ago

@hervelemeur Damian can correct me here, but I think it was originally added to build on Windows. This may be redundant now that the Jenkinsfile specifies building on Windows.

I contributed the JDK17 enhancement here because it's often easier on maintainers to accept contributions that keep builds green than require a build be shut down.