search

jenkinsci / build-timeout-plugin

Jenkins build-timeout plugin
https://plugins.jenkins.io/build-timeout/
31 stars 80 forks source link

[FIXED JENKINS-19826] - Refactored percentage configuration approach. #16

Closed oleg-nenashev closed 2 years ago

oleg-nenashev commented 10 years ago

Just for review... Is this change applicable or should I restore f:select?

Fix is not very graceful, but it also resolves issue with non-standard percentage timeouts. Probably, MAX limit should be changed...

Signed-off-by: Oleg Nenashev nenashev@synopsys.com

oleg-nenashev commented 10 years ago

This patch resolves JENKINS-19826 only for a single plugin. BTW, seems that fix should e done on the core's level

darxriggs commented 5 years ago

@oleg-nenashev can this be closed unmerged? It seems to be fixed in Jenkins core - right?

krisstern commented 2 years ago

I am of the opinion that this PR should be closed un-merged, as the matter should be and appears to have been resolved at the core level of Jenkins instead of at the individual plugin level.

krisstern commented 2 years ago

@darxriggs Thanks for the comment at https://github.com/jenkinsci/build-timeout-plugin/pull/16#issuecomment-528062983