[FIXED JENKINS-29163] Added Deadline timeout strategy

[fmiguelez]

I added the functionality described in the ticket. It works, I tested it with multi-configuration projects and created a unit test.

Ikedam please review the pull request in case you have any suggestions before merging it.

[ikedam]

The functionality looks perfect.

• Your code looks for older Jenkins. You might try writing in the modern way if you interested in that (but not so modern, as build-timeout targets older Jenkins core). You may have a look at NoActivityTimeOutStrategy.
  • You can annotate directly the sub-class ofDescriptor with @Extension directly. You no longer need to instantiate Descriptor.
  • Using Messages.properties for getDisplayName is recommended as it allows internationalization in future.

[ikedam]

Accepting variables would be useful. E.g. You can configure the deadline globally with system variables.

[ikedam]

The time getTimeOut is called is after the build gets out from the build queue and after checking out SCM. If you don't like that, following APIs may help you.

• Run#getTimestamp
• Run#getStartTimeInMillis
• Run#getRootBuild

[ikedam]

link to JIRA JENKINS-29163.

[fmiguelez]

Regarding using variables I will definetly include it.

[fmiguelez]

I close this pull request and recreate another one with the suggested improvements.

[ikedam]

JFYI: You can continue this request. Just pushing additional commits to your repository updates this request automatically. (in that case, github doesn't notify me the update and you have to comment that you make updates)

Of course, you can recreate a new request. You can do as you prefer.

[fmiguelez]

Ok I will do as you mention, I had no idea.

[fmiguelez]

ikedam, is it ok if I merge now the pull request?

[ikedam]

Many unrelated changes to BuildTimeOutStrategy. You can see your changes in the "Files changed" tab.

Let's turn off your IDE auto-formatting for existing codes, and don't make unrelated changes to existing codes as:

• It makes it hard to review your changes.
• It makes it hard to track bugs (e.g. what version intruduced the bug?) with git blame.
  • Please commit the next change to revert BuildTimeOutStrategy with git commit --ammend to overwrite the last commit. That makes git blame work correct.
• It conflicts with other pull requests (I know this is not applicable to this request as there's no other active pull requests for build-timeout plugin).

I prefer to leave existing codes unchanged even if I know they are formatted badly.

[fmiguelez]

Sorry for that. I usually let Eclipse do the formatting and imports organizing on save action. I think I fixed BuildTimeoutOutStrategy as you requested. Now only my changes at the bottom show up. I needed some trial and error (not really familiar with git yet :( ) .

[ikedam]

Looks good to me. Please let me merge this request manually, squashing your last some commits together.

This request contains commits confusing git blame like this: https://github.com/fmiguelez/build-timeout-plugin/blame/c04fab08ab89313e594eae8950939ec3cfc94fc0/src/main/java/hudson/plugins/build_timeout/BuildTimeOutStrategy.java (you can reach that page from "Files Changed" > "View" > "Blame")

This can be resolved by squashing commits after "[CHG]..." together using several git commands. Let me have time for that work.

[ikedam]

I rearranged commits in #40 (Preserves your commit comments, but SHA-1 is changed). Could you have a look on the request and see your change is preserved?

[fmiguelez]

Great work. Content matches in both pull requests. We can close this pull request and merge #40 then.