jenkinsci / build-timeout-plugin

Jenkins build-timeout plugin

https://plugins.jenkins.io/build-timeout/

31 stars 80 forks source link

[JENKINS-29357] Fixed findbugs warnings in DeadlineTimeoutStrategy #42

Closed ikedam closed 9 years ago

ikedam commented 9 years ago

JENKINS-29357

41 introduced findbugs and that discovered some possible problems in DeadlineTimeoutStrategy, introduced in #39.

ikedam commented 9 years ago

@fmiguelez You may be interested in this change. I'll plan to make a new release with DeadlineTimeoutStrategy feature this weekend after merging this change.

You can see the behavior of findbugs with mvn findbugs:findbugs with the latest master after compiling source codes. You might need to add -Dfindbugs.jvmArgs=-Duser.language=en if that fails with errors.

fmiguelez commented 9 years ago

I am still working with JVM 1.6 and findbugs seems not work :( . I did not know of that tool. Thanks for the advice. Great that you already performed the suggested improvements.

If you plan to release a new version it would be a good idea to translate new literals into Japanese. I can not help you with that :-( . You can translate new literals into Japanese if you want to. I can however add Spanish translations if you think it would be a nice feature.

ikedam commented 9 years ago

You can see the outputs from findbugs on Jenkins:

Before this change: https://jenkins.ci.cloudbees.com/job/plugins/job/build-timeout-plugin/88/
After this change: https://jenkins.ci.cloudbees.com/job/plugins/job/build-timeout-plugin/89/

Ok, I'll postpone the new release a little and add Japanese translations for DeadlineTimeoutStrategy. I don't think we have to add Spanish translations as there have been no Spanish tranlations for existing features. Of cource, you can add Spanish translations partially e.g. only to DeadlineTomeout.

fmiguelez commented 9 years ago

I meant adding Spanish translations to all literals present in build-timeout-plugin, of course, not only those affecting DeadlineTimeoutStrategy. There are just a few. I could have them translated by tomorrow.

If it is OK to include the translations I could commit changes directly to master branch instead of creating a pull request from my fork copy if you prefer it.

ikedam commented 9 years ago

I prefer to create pull requests for any changes as some developers might give comments for that, in this case, ones who know Spanish. (though it's not so often that someone give comments to pull requests...)