jenkinsci / build-timeout-plugin

Jenkins build-timeout plugin
https://plugins.jenkins.io/build-timeout/
31 stars 80 forks source link

No support for "No Activity" strategy via the <timeoutType> element #52

Closed nmishkin closed 8 years ago

nmishkin commented 8 years ago

It looks like the cascading if/then/else statement in BuildTimeoutWrapper.readResolve() needs an arm for "no-activity".

ikedam commented 8 years ago

Unnecessary. I don't think you know what readResolve is.

nmishkin commented 8 years ago

No doubt. How I got down this path though was a result of my trying to use the timeout "wrapper" in Jenkins Job Builder. It generates Jenkins job XML that includes text like what I've attached. Please let me know if this XML is incorrect, in which case I'll get in touch with the Jenkins Job Builder people. Thanks.

job.xml

ikedam commented 8 years ago

Unfortunately, it looks that Jenkins Job Builder people have never test their software or documentation. The word "no-activity" have never used in configuration xml of build-timeout plugin. Jenkins Job Builder looks work with the configuration of build-timeout <= 1.11, and doesn't support features introduced >= 1.12.

ikedam commented 8 years ago

It rather should be handled here: https://github.com/openstack-infra/jenkins-job-builder/blob/1.4.0/jenkins_jobs/modules/wrappers.py#L209

You might use jenkins-job-builder <= 1.2.0. Upgrade to the latest version.