search

jenkinsci / build-timeout-plugin

Jenkins build-timeout plugin
https://plugins.jenkins.io/build-timeout/
31 stars 80 forks source link

Add build step with timeout feature #61

Closed Jimilian closed 7 years ago

Jimilian commented 7 years ago

Sometimes it's much better to have several small timeouts instead of one global one.

Jimilian commented 7 years ago

Ok, everything is done (I hope). I added a couple of tests for basic mechanic.

ikedam commented 7 years ago

Would you tell me more details about "conditional steps doesn't work if it's used at child" ? As far as I tested, it looks work with BuildStepWithTimeout as expected (tested with Jenkins 1.651 and condition Always and Never work as expected).

I believe this is an important issue as conditional buildstep can be used as "multiple steps".

Jimilian commented 7 years ago

Thanks for your suggestions - I made some refactoring for tests. Now even I'm satisfied with them :)

Would you tell me more details about "conditional steps doesn't work if it's used at child" ?

I don't have many details... just empty list of builders. No logs, no asserts, nothing in js console as well. screen shot 2016-10-31 at 10 14 41

This happens on Jenkins ver. 1.632, but I wasn't able to repeat it on Jenkins ver. 1.651.3.

As far as I tested the behavior, stacktraces aren't output into build logs (console logs), but are output only into system logs. Can I know more details about why you want to suppress InterruptedException?

I removed suppressing (as well as additional executions of setResult). In first place I mainly tested this plugin with "embedded" Jenkins version (1.466) and in 1.466 user receives exception in console, but this issue doesn't happen in 1.651.3.

ikedam commented 7 years ago

As far as I know, InterruptedException isn't printed even in Jenkins-1.466. Any way, I like the new change. Thanks!

This happens on Jenkins ver. 1.632, but I wasn't able to repeat it on Jenkins ver. 1.651.3.

Sorry, I missed that problem. It's a bug of f:dropdownDescriptorSelector and fixed in Jenkins 1.645+ (jenkinsci/jenkins#1184). Plugins can backport f:dropdownDescriptorSelector from Jenkins 1.645+ to fix that problem (like authorize-project-plugin). You can create a new pull request to do that if you want to fix that problem

ikedam commented 7 years ago

I plan to make a new release in the next weekend (11th or 12th Nov)

ikedam commented 7 years ago

Released 1.18. It will be available on the update center in a day.