Use JUnit 4 consistently

jenkinsci / build-timeout-plugin

Jenkins build-timeout plugin

https://plugins.jenkins.io/build-timeout/

31 stars 80 forks source link

Use JUnit 4 consistently #73

Closed darxriggs closed 2 years ago

darxriggs commented 4 years ago

use @Test annotation only instead of "test" prefix (JUnit 3) or annotation mixed with prefix
use JenkinsRule instead of HudsonTestCase (JUnit 3)
use TemporaryFolder instead of manual temporary folder handling

darxriggs commented 4 years ago

@ikedam can you please exactly describe what is missing in your opinion? I think I provided all required information.

The title exactly describes what this pull request is about - "consistency". It makes all tests consistently use JUnit 4 and its features.

The description and commit comment contains all details summarized in a way to get a quick overview of the changes.

ikedam commented 4 years ago

Background: https://github.com/jenkinsci/build-timeout-plugin/pull/72#issuecomment-562893390

krisstern commented 2 years ago

Thanks @darxriggs for this PR! I think the changes are desirable and will highly likely approve and merge this PR after some more careful reviewing. Appreciate it!

Although I will have to admit by 2022 it is perhaps time to upgrade to JUnit 5 soon. There will be a new issue coming out regarding this over the next week or so.