Edit View and Non-Word chars in groupClass Fixes

jenkinsci / categorized-view-plugin

This is a plugin to create a new view named Categorized Jobs View, where jobs are grouped dynamically by regular expressions

https://plugins.jenkins.io/categorized-view/

GNU General Public License v3.0

11 stars 23 forks source link

Edit View and Non-Word chars in groupClass Fixes #1

Closed cylab closed 10 years ago

cylab commented 10 years ago

Fixed job selector in edit view screen Actually I replaced the section in configure-entries.jelly with the original form the ListView. I don't know what the recurse into subdirectory stuff should do, but given that it broke normal behaviour, I just removed it
Fixed preservation of column configuration On every restart, the column list was reinitialized, so I added a check for null before doing so
Fixed bug with non-word characters while generating a groupClass name … getGroupClass() only replaced spaces and dots, so it broke the javascipt if you used brackets and such in your group labels. I replaced everything not being A-Z0-9 with underscores and added the original Strings' hashCode to make it unique for sure

And sorry for the reformat :-/

jenkinsadmin commented 10 years ago

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

cloudbees-pull-request-builder commented 10 years ago

plugins » categorized-view-plugin #1 FAILURE Looks like there's a problem with this pull request

cylab commented 10 years ago

Actually I don't know what to do - for me the failure looks like a connectivity problem on the cloudbees side...

taksan commented 10 years ago

Hi Cylab

Thanks for your fixes to the plugin. Your fixes are very welcome! Just a minor request: could you please redo the pull request with just the actual changes, without the reformatting? I think the code reformatting makes the change log harder to read.

Thanks again

cloudbees-pull-request-builder commented 10 years ago

plugins » categorized-view-plugin #2 FAILURE Looks like there's a problem with this pull request

cloudbees-pull-request-builder commented 10 years ago

plugins » categorized-view-plugin #3 SUCCESS This pull request looks good

cylab commented 10 years ago

ping :)

taksan commented 10 years ago

Sorry, I didn't notice at the time that you did reapply without reformatting. Anyway, I merged your changes and I'm making a new release with them.