jenkinsci / categorized-view-plugin

This is a plugin to create a new view named Categorized Jobs View, where jobs are grouped dynamically by regular expressions
https://plugins.jenkins.io/categorized-view/
GNU General Public License v3.0
11 stars 23 forks source link

Use local storage to store group collapse state #19

Closed amezin closed 4 years ago

amezin commented 4 years ago

Storing it in cookies causes "Bad Message 431 reason: Request Header Fields Too Large" when there are many jobs.

Fixes #18

Signed-off-by: Aleksandr Mezin mezin.alexander@gmail.com

amezin commented 4 years ago

@taksan You've approved this PR, but didn't merge it (yet) - what does it mean?

Also, I'm looking at catSortable.js, it gets sessionStorage object through YAHOO.util.StorageManager.get: https://github.com/jenkinsci/categorized-view-plugin/blob/master/src/main/webapp/catSortable.js#L360

Should I do the same thing here? Does YAHOO.util.StorageManager.get have any advantages over raw localStorage/sessionStorage?