search

jenkinsci / categorized-view-plugin

This is a plugin to create a new view named Categorized Jobs View, where jobs are grouped dynamically by regular expressions
https://plugins.jenkins.io/categorized-view/
GNU General Public License v3.0
11 stars 24 forks source link

Remove usages of Prototype from Categorized View #31

Closed basil closed 1 year ago

basil commented 1 year ago

See this blog post for details. Prototype will eventually be removed from Jenkins core. To prepare for this transition, this plugin must be migrated away from Prototype. The blog post contains instructions on how to find and eliminate usages of Prototype. In this plugin, the following usages of Prototype have been identified. This may not be an exhaustive list:

./src/main/resources/lib/categorizedview/catProjectView.jelly:99:    $$("table.categorizedSortable").each(function(e){
./src/main/resources/lib/categorizedview/catProjectViewRow.jelly:51:        document.observe("dom:loaded", function() {
./src/main/resources/org/jenkinsci/plugins/categorizedview/CategorizedJobsView/configure-entries.jelly:87:       var nestedElements = $$('SPAN.nested')
./src/main/resources/org/jenkinsci/plugins/categorizedview/CategorizedJobsView/configure-entries.jelly:89:         nestedElements.each(function(el) {
./src/main/resources/org/jenkinsci/plugins/categorizedview/CategorizedJobsView/configure-entries.jelly:90:           e.checked ? el.show() : el.hide();
./src/main/webapp/sectionToggle.js:3:    handle = $$("#handle_" + groupName).first();
./src/main/webapp/sectionToggle.js:12:    var handle = $$("#handle_" + group).first();
./src/main/webapp/sectionToggle.js:22:    $$('.' + group).each(
./src/main/webapp/sectionToggle.js:28:    var src = $$("#handle_" + group + " img").first().src;
./src/main/webapp/sectionToggle.js:30:    $$("#handle_" + group + " img").first().src = src;
./src/main/webapp/sectionToggle.js:35:    $$('.' + group).each(
./src/main/webapp/sectionToggle.js:38:            $(e).setOpacity(0)
./src/main/webapp/sectionToggle.js:47:    var src = $$("#handle_" + group + " img").first().src;
./src/main/webapp/sectionToggle.js:49:    $$("#handle_" + group + " img").first().src = src;
./src/main/webapp/sectionToggle.js:72:    localStorage.setItem("jenkins.categorized-view-collapse-state_" + viewName, Object.toJSON(groupStates));
./src/main/webapp/catSortable.js:57:        firstRow.each(function (cell) {
./src/main/webapp/catSortable.js:71:            firstRow.each(function (cell, i) {
./src/main/webapp/catSortable.js:98:                return $A(this.table.rows[0].cells);
./src/main/webapp/catSortable.js:197:                if (r.hasClassName("sorttop")) return 0;
./src/main/webapp/catSortable.js:198:                if (r.hasClassName("sortbottom")) return 2;
./src/main/webapp/catSortable.js:223:            rows.each(function (e) {
./src/main/webapp/catSortable.js:228:            this.arrows.each(function (e, i) {

CC @taksan

basil commented 1 year ago

Released in 1.13.