Should judge null when get jenkins http proxy setting - Githubissues

jenkinsci / cdevents-plugin

The CDEvents Plugin for Jenkins allows interoperability between different CI/CD tools by adopting core CDF project specification

https://plugins.jenkins.io/cdevents/

Apache License 2.0

4 stars 9 forks source link

Should judge null when get jenkins http proxy setting #9

Closed wuhuizuo closed 11 months ago

wuhuizuo commented 1 year ago

Describe the bug when no http proxy setting, cd events failed to send by http sinker type.

To Reproduce Steps to reproduce the behavior:

None http proxy setting on jenkins server.
Set http sinker type.
Run a job
view the jenkins system log.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Jenkins version: 2.401.3
plugin version: 1-24.v0250517580b_2
Problem code lines: https://github.com/jenkinsci/cdevents-plugin/blob/2780c2d1d9c9e19310763579c52fdd3b71c3b6ee/src/main/java/io/jenkins/plugins/cdevents/sinks/HttpSink.java#L29-L30

rorybakerfmr commented 11 months ago

Good summary and pull request - we have accepted these changes. Thank you!