jenkinsci / checks-api-plugin

Jenkins plugin that defines an API for Jenkins to publish checks to SCM platforms.
https://plugins.jenkins.io/checks-api/
MIT License
43 stars 28 forks source link

Add commons-text-api dependency #234

Closed timja closed 1 year ago

timja commented 1 year ago

Fixes https://github.com/jenkinsci/checks-api-plugin/issues/233

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
codecov[bot] commented 1 year ago

Codecov Report

Merging #234 (0382b29) into master (33c675e) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage     85.38%   85.38%           
  Complexity      152      152           
=========================================
  Files            17       17           
  Lines           746      746           
  Branches         57       57           
=========================================
  Hits            637      637           
  Misses           89       89           
  Partials         20       20           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jglick commented 1 year ago

I would recommend ceasing to use analysis-pom as a parent.

timja commented 1 year ago

I would recommend ceasing to use analysis-pom as a parent.

agreed but this was a minimum quick change, (PRs welcome)