jenkinsci / checks-api-plugin

Jenkins plugin that defines an API for Jenkins to publish checks to SCM platforms.
https://plugins.jenkins.io/checks-api/
MIT License
43 stars 28 forks source link

Local build doesn't fail for checkstyle or spotbugs #99

Closed timja closed 6 months ago

timja commented 3 years ago

Pretty frustrating, what is your workflow for this @uhafer?

I run mvn clean install and then I create a PR and it fails for spotbugs or checkstyle

uhafner commented 3 years ago

I normally never use maven locally 😄

I commit (and IntelliJ starts CheckStyle and SpotBugs Issues before the commit). That is typically enough for me. The problem with maven is that it cannot check for new issues.

timja commented 3 years ago

Do you have a pre commit hook that runs them?

i.e how do you have it setup to run those?

uhafner commented 3 years ago

I'm just using the checkstyle and spotbugs plugins:

Bildschirmfoto 2021-04-01 um 20 18 28

basil commented 2 years ago

The problem with maven is that it cannot check for new issues.

There is at least some precedent for ratcheting functionality in Spotless Maven Plugin.