jenkinsci / cloud-stats-plugin

Aggregate past cloud provisioning activities into a report
https://plugins.jenkins.io/cloud-stats/
MIT License
11 stars 20 forks source link

Test Linux JDK 17 in CI #58

Closed npotluri-rh closed 1 year ago

npotluri-rh commented 1 year ago

Adding JDK version 17 with specific jenkins version to test if it runs on CI with no issues

MarkEWaite commented 1 year ago

I don't understand the motivation for the change. JDK 17 is already being tested on Windows. We intentionally chose to keep CI costs down. Is there a compelling reason that we need Java 17 testing on both Windows and Linux?

olivergondza commented 1 year ago

@MarkEWaite, We are primarily interested in linux support with java 11 and 17, no objection to test windows as well. Would you say testing win+j17 provides good enough guarantee java 17 is covered on linux as well?

One thing that comes to mind is: https://github.com/jenkinsci/cloud-stats-plugin/blob/9294e95bce45bfa0779c94a824d79f91162df894/src/test/java/org/jenkinsci/plugins/cloudstats/CloudStatisticsTest.java#L209

MarkEWaite commented 1 year ago

@MarkEWaite, We are primarily interested in linux support with java 11 and 17, no objection to test windows as well. Would you say testing win+j17 provides good enough guarantee java 17 is covered on linux as well?

One thing that comes to mind is:

https://github.com/jenkinsci/cloud-stats-plugin/blob/9294e95bce45bfa0779c94a824d79f91162df894/src/test/java/org/jenkinsci/plugins/cloudstats/CloudStatisticsTest.java#L209

I don't recall ever detecting a problem on Java 17 Linux that was not also detected on Java 17 Windows, but I also understand your strong desire to be absolutely certain that the code is well behaved on Java 17 Linux. I have felt that same strong desire with a few of the plugins that I maintain. You and @npotluri-rh have my full support for the addition of Java 17 Linux as a test configuration.

Thanks for explaining!