jenkinsci / cloud-stats-plugin

Aggregate past cloud provisioning activities into a report
https://plugins.jenkins.io/cloud-stats/
MIT License
11 stars 20 forks source link

Implement WidgetFactory for CloudSet #73

Closed Vlatombe closed 1 year ago

Vlatombe commented 1 year ago

Downstream of https://github.com/jenkinsci/jenkins/pull/7932

This lets the plugin leverage the new extension point to show the stats widgets in the CloudSet view where it makes sense the most.

Screenshot (didn't have relevant data but that lets you see the layout)

Capture d’écran 2023-05-05 à 17 36 25

Testing done

Submitter checklist

timja commented 1 year ago

Ux doesn’t look good to me I probably wouldn’t add widgets to this page I don’t think it gives any value.

jglick commented 1 year ago

Well there was a widget already; this is basically moving it to the clouds view rather than dashboard.

timja commented 1 year ago

Well there was a widget already; this is basically moving it to the clouds view rather than dashboard.

It's duplicating it isn't it?

A link to the stats in the app bar would look better I think not putting it in the sidebar which makes the page look unbalanced

Vlatombe commented 1 year ago

A link to the stats in the app bar would look better I think not putting it in the sidebar which makes the page look unbalanced

Yes, I figure the plugin would need some work to leverage the new real estate provided by the manage clouds screen.

Vlatombe commented 1 year ago

Closing as the tentative change was removed from the core api.