jenkinsci / code-coverage-api-plugin

Deprecated Jenkins Code Coverage Plugin
https://plugins.jenkins.io/code-coverage-api/
MIT License
111 stars 77 forks source link

Do not use color for unchanged coverage #777 #789

Closed Amanjain4269 closed 10 months ago

Amanjain4269 commented 10 months ago

Changes the coloring of the delta in the overview: small changes < 0.01 percent will be not color. All other changes will be colored as before (positive: green, negative: red).

Bildschirmfoto 2023-10-18 um 14 55 32

Amanjain4269 commented 10 months ago

Thanks for the reviews.

I made the changes in another commit. Can you please check now?

Amanjain4269 commented 10 months ago

I made a new commit. Please check now.

Also, there is one more thing I want to mention. I think there are errors in the changes I made in the coverage-summary.jelly file, as the checks are failing. I tried another approach in this new commit but still the same. Can you help me out with this?

Amanjain4269 commented 10 months ago

@uhafner

Thanks for your valuable insights.

I made the final changes.

codecov[bot] commented 10 months ago

Codecov Report

Merging #789 (c0a2b1c) into master (8106422) will increase coverage by 0.11%. Report is 7 commits behind head on master. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #789      +/-   ##
============================================
+ Coverage     74.14%   74.26%   +0.11%     
- Complexity     1705     1710       +5     
============================================
  Files           130      130              
  Lines          6301     6302       +1     
  Branches        677      675       -2     
============================================
+ Hits           4672     4680       +8     
+ Misses         1407     1399       -8     
- Partials        222      223       +1     
Files Coverage Δ
...ns/coverage/metrics/steps/CoverageBuildAction.java 74.28% <100.00%> (+5.22%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Amanjain4269 commented 10 months ago

@uhafner
Is everything OK now?

uhafner commented 10 months ago

Thanks for your patience!