jenkinsci / configuration-as-code-plugin

Jenkins Configuration as Code Plugin
https://plugins.jenkins.io/configuration-as-code
MIT License
2.69k stars 718 forks source link

Introduce a new JCasC Test Harness Library #917

Closed oleg-nenashev closed 4 years ago

oleg-nenashev commented 5 years ago

Your checklist for this issue

🚨 Please review the guidelines for contributing to this repository.

Feature Request

It looks like we have a lot of test framework functionality for JCasC:

Currently it is hard to reuse this code, because it is located within the test suites, so an odd dependency is needed. Also, it makes the downstream plugins to pull in more test dependencies than we really want.

    <dependency>
      <groupId>io.jenkins</groupId>
      <artifactId>configuration-as-code</artifactId>
      <version>${configuration-as-code.version}</version>
      <classifier>tests</classifier>
      <scope>test</scope>
    </dependency>

What if we introduce a new configuration-as-code-test-harness component which would ship it in a library?

    <dependency>
      <groupId>io.jenkins</groupId>
      <artifactId>configuration-as-code-test-harness</artifactId>
      <version>${configuration-as-code.version}</version>
      <scope>test</scope>
    </dependency>
timja commented 5 years ago

Yes, I believe we discussed it before, last time there was a packaging issue with the test classifier, we did the quick fix at the time but a separate module would be good in my opinion

MRamonLeon commented 5 years ago

LGTM :heart:

timja commented 4 years ago

resolved in https://github.com/jenkinsci/configuration-as-code-plugin/pull/1215

oleg-nenashev commented 4 years ago

I believe it is fixed by @timja in https://github.com/jenkinsci/configuration-as-code-plugin/pull/1215

oleg-nenashev commented 4 years ago

ERR_RACE_CONDITION