search

jenkinsci / custom-distribution-service

Archived in https://github.com/jenkins-infra/helpdesk/issues/3126. The project wasn't completed. The main idea behind the project is to build a customizable jenkins distribution service :package: that could be used to build tailor-made jenkins distributions
https://customize.jenkins.io/pluginList
MIT License
21 stars 16 forks source link

Cleanup Tasks #86

Open sladyn98 opened 4 years ago

sladyn98 commented 4 years ago

a) Unused variables

b) Generate War file errors should be properly handled if the configuration file format is incorrect

martinda commented 4 years ago

The warnings in the cds_frontend in the js files need to be fixed:

cds_front-end | ./src/components/PackageGeneration/Editor.js
cds_front-end |   Line 12:7:   'code' is assigned a value but never used         no-unused-vars
cds_front-end |   Line 48:21:  Expected '===' and instead saw '=='               eqeqeq
cds_front-end |   Line 68:11:  'packageJSON' is assigned a value but never used  no-unused-vars
cds_front-end | 
cds_front-end | ./src/components/PluginCards/pluginCard.js
cds_front-end |   Line 16:5:   Useless constructor                            no-useless-constructor
cds_front-end |   Line 21:23:  The object literal notation {} is preferrable  no-new-object
cds_front-end |   Line 23:26:  The object literal notation {} is preferrable  no-new-object
cds_front-end | 
cds_front-end | ./src/components/CommunityConfiguration/communityConfigLayout.js
cds_front-end |   Line 2:8:    'PluginCard' is defined but never used                   no-unused-vars
cds_front-end |   Line 5:45:   'Label' is defined but never used                        no-unused-vars
cds_front-end |   Line 31:61:  Expected to return a value at the end of arrow function  array-callback-return
cds_front-end | 
cds_front-end | ./src/components/modal.js
cds_front-end |   Line 37:22:  The object literal notation {} is preferrable  no-new-object
cds_front-end | 
cds_front-end | ./src/components/CommunityConfiguration/configurationCard.js
cds_front-end |   Line 4:16:  'CardSubtitle' is defined but never used  no-unused-vars
cds_front-end |   Line 14:5:  Useless constructor                       no-useless-constructor
cds_front-end | 
cds_front-end | ./src/components/layouts/CardLayout.js
cds_front-end |   Line 4:54:    'Label' is defined but never used                        no-unused-vars
cds_front-end |   Line 48:50:   Expected to return a value in arrow function             array-callback-return
cds_front-end |   Line 78:50:   Expected to return a value at the end of arrow function  array-callback-return
cds_front-end |   Line 186:58:  Expected '===' and instead saw '=='                      eqeqeq
cds_front-end | 
cds_front-end | ./src/components/layouts/Header.js
cds_front-end |   Line 9:6:   The href attribute requires a valid value to be accessible. Provide a valid, navigable address as the href value. If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md         jsx-a11y/anchor-is-valid
cds_front-end |   Line 15:8:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
cds_front-end |   Line 20:8:  The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid