Upgrade Parent POM and enable FindBugs

jenkinsci / custom-tools-plugin

A generic tool installer for Jenkins

https://plugins.jenkins.io/custom-tools-plugin

Other

25 stars 36 forks source link

Upgrade Parent POM and enable FindBugs #25

Closed oleg-nenashev closed 8 years ago

oleg-nenashev commented 9 years ago

[x] Bump core dependency to 1.580.x (required for Pipeline in any case)
[x] Fix issues in Javadoc
[x] Escape Jelly files by default
[x] Cleanup FindBugs

@reviewbybees

ghost commented 9 years ago

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

oleg-nenashev commented 9 years ago

And let's trigger FindBugs now

jenkinsadmin commented 9 years ago

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

jtnord commented 8 years ago

:bug: for not using MasterToSlaveFileCallable where appropriate.

oleg-nenashev commented 8 years ago

@jtnord I suppose your old bug has been addressed

abayer commented 8 years ago

:bee:

jtnord commented 8 years ago

:bee: to unblock - but JenkinsHelper appears to not be needed according to the comment.

oleg-nenashev commented 8 years ago

The idea was to use getActiveInstance(). But this approach is also deprecated in the core, hence I'll keep the Util class for a while till the version gets bumped again. The class is restricted in any case