[WIP][JENKINS-30680] Pipeline compatibility

jenkinsci / custom-tools-plugin

A generic tool installer for Jenkins

https://plugins.jenkins.io/custom-tools-plugin

Other

25 stars 36 forks source link

[WIP][JENKINS-30680] Pipeline compatibility #27

Open alexbrjo opened 7 years ago

alexbrjo commented 7 years ago

Pipeline compatibility. see JENKINS-30680

[X] Compatibility with pipeline
[X] Snippet generator
[X] Used tools action added to job
- [ ] aesthetic jelly for the action page
[ ] backwards / binary compatibility

Implementation Since BuildWrapper#decorateLauncher() is only honored for AbstractProject's, I tried to keep parity between FreeStyle and Workflow jobs by moving the logic for adding environment variables to BuildWrapper#setup()

oleg-nenashev commented 7 years ago

@alexbrjo Hi Alex. FYI I have reopened this pull-request. I am working on removing Extended Choice dependency as a part of JENKINS-32662 / JENKINS-46141/other such issues.

It apepars it is not possible to do the refactoring in a compatible way due to the architecture issues I have introduced in 2013. But it's too hot due to the security issue in Extended Choice, so I lean towards breaking the compatibility and releasing 1.0.

It makes the current pull request compliant, so I will probably refactor and land this pull request in 1.0

oleg-nenashev commented 7 years ago

FTR the parallel work is here: https://github.com/jenkinsci/customtools-plugin/pull/29