Restricted JenkinsHelper and DecoratedLauncher

jenkinsci / custom-tools-plugin

A generic tool installer for Jenkins

https://plugins.jenkins.io/custom-tools-plugin

Other

25 stars 36 forks source link

Restricted JenkinsHelper and DecoratedLauncher #28

Closed alexbrjo closed 7 years ago

alexbrjo commented 7 years ago

JenkinsHelper and DecoratedLauncher were copied from core when this plugin depended on an earlier version without these features. ArrayHelper is unused. I could not find any usages of these helper classes so I think can be dropped.

There should be no functional changes in this PR. Trying to reduce the diff of #27

@jenkinsci/code-reviewers

oleg-nenashev commented 7 years ago

@alexbrjo Why have you closed it?

alexbrjo commented 7 years ago

@oleg-nenashev This was a complement to #27 (the pipeline compatibility PR). Enough needed to be changed that it would be easier to rewrite from scratch (which I attempted).