search

jenkinsci / custom-tools-plugin

A generic tool installer for Jenkins
https://plugins.jenkins.io/custom-tools-plugin
Other
25 stars 36 forks source link

[JENKINS-54154] - Fix configuration-as-code support #31

Closed ndeloof closed 6 years ago

ndeloof commented 6 years ago

API-breaking change

really ? On couldn't have used this constructor with a List of anything but ToolProperty, so I assume there's no actual breaking change.

ansig commented 6 years ago

Any chance of seeing this merged and released soon if it is not a breaking change? https://github.com/jenkinsci/configuration-as-code-plugin/issues/97 is a blocker for me.

oleg-nenashev commented 6 years ago

really ? On couldn't have used this constructor with a List of anything but ToolProperty, so I assume there's no actual breaking change.

You are right, it's not according to the specs

oleg-nenashev commented 6 years ago

There was no JIRA for it, so I just missed it. https://issues.jenkins-ci.org/browse/JENKINS-54154 has been created