search

jenkinsci / custom-tools-plugin

A generic tool installer for Jenkins
https://plugins.jenkins.io/custom-tools-plugin
Other
25 stars 36 forks source link

[JENKINS-53146]Adding ENV variables to build #33

Open alexanderrtaylor opened 5 years ago

alexanderrtaylor commented 5 years ago

Adding HOME ENV variables to build.getEnvironments so that plugins can pull in the homes of custom tests if needed

I am not sure how to develop tests though..... I needed another plugin to prove this was fixed. Anyone have suggestions? Otherwise the actual issue is fixed @reviewbybees

recampbell commented 5 years ago

Can you describe how you tested this manually?

recampbell commented 5 years ago

It seems like we need some tests which validate that environment variables provided by build#getEnvironment

alexanderrtaylor commented 5 years ago

@oleg-nenashev Do you have time to give this a 🐝 ?

alexanderrtaylor commented 5 years ago

I checked to see if the tools had been defined in the last commit which means it should be checking for the build wrapper before injecting and it works even while the build does not inject any custom tools.

alexanderrtaylor commented 5 years ago

@oleg-nenashev do you have time to give this a re-review? I am trying to figure out if just checking if the custom tools are configure is sufficient to prevent this chicken/egg problem or if there is something else I should be looking for

oleg-nenashev commented 5 years ago

Hi. Sorry, no plans to work on this plugin till May at least. Feel free to take ownership if needed

On Thu, Mar 28, 2019 at 9:47 PM Alex Taylor notifications@github.com wrote:

@oleg-nenashev https://github.com/oleg-nenashev do you have time to give this a re-review? I am trying to figure out if just checking if the custom tools are configure is sufficient to prevent this chicken/egg problem or if there is something else I should be looking for

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jenkinsci/custom-tools-plugin/pull/33#issuecomment-477764928, or mute the thread https://github.com/notifications/unsubscribe-auth/AC3IoGYono99PjMDHqh8A0QybLFWBk25ks5vbSpxgaJpZM4Zlm6C .