jenkinsci / custom-war-packager

Custom Jenkins WAR packager for Jenkins
https://jenkins.io/blog/2018/10/16/custom-war-packager/
MIT License
87 stars 69 forks source link

[JENKINS-56270] - Support Including shared libraries in Jenkinsfile Runner #124

Open belsander opened 6 years ago

belsander commented 6 years ago

Hi,

Thanks for the work! I'm however looking into including a shared library to validate our Jenkinsfiles, but I do not know how to proceed. Could you help me out?

Thanks!

OliverNocon commented 5 years ago

Hi,

You could do this by using JCasC plugin and define your lib in the config.yml. Here the example how the lib details can be defined: https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/demos/workflow-cps-global-lib. Best regards.

fwilhe commented 5 years ago

Hey @belsander,

in the meantime this is really easy to solve using Configuration as Code as mentioned by @OliverNocon. I've described it for a specific case in a blog post, should be really simple to adopt for other cases. I think this issue can be closed.

oleg-nenashev commented 5 years ago

My plan is to have support of packaging libraries with Custom WAR Packager flow: https://issues.jenkins-ci.org/browse/JENKINS-56100

https://jenkins.io/blog/2018/10/16/custom-war-packager/ explains the flow for custom packages

oleg-nenashev commented 5 years ago

@fwilhe Just in case you are interested, your blog could be reposted on https://jenkins.io/node/ . It would be an interesting case study. CC @tracymiranda

W.r.t rhis particular issue, I am going to close it. JCasC formally addresses the request (see the blogpost), the rest will be automated in https://issues.jenkins-ci.org/browse/JENKINS-56100 .

fwilhe commented 5 years ago

@oleg-nenashev @tracymiranda I'd love to share the post in other places. What would I need to do for that?

oleg-nenashev commented 5 years ago

@fwilhe We use configuration-as-code so you can just submit a pull request to https://github.com/jenkins-infra/jenkins.io. Guidelines: https://github.com/jenkins-infra/jenkins.io/blob/master/CONTRIBUTING.adoc#adding-a-blog-post

fwilhe commented 5 years ago

Submitted a PR :)

Thanks for the offering!

oleg-nenashev commented 5 years ago

Removing Hacktoberfest label, because the easiest way (Filesystem SCM Plugin) has a published unresolved security issues. Ideally it needs a proper solution on the Pipeline Side instead (Lirary Source extension)