jenkinsci / customizable-header-plugin

Customizable header for Jenkins
https://plugins.jenkins.io/customizable-header/
MIT License
4 stars 2 forks source link

fix hanging request on wrong path to svg #80

Closed mawinter69 closed 4 months ago

mawinter69 commented 4 months ago

when using a SVGLogo and providing a non existent path or a non existent url leads to a hanging ui as the http request seems to hang forever. The cause are the new 404 pages, that include the header itself and a missing timeout on the connection. Properly handle the return code when loading from a url

Increase the caching period to 1 hour

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue