jenkinsci / customizable-header-plugin

Customizable header for Jenkins
https://plugins.jenkins.io/customizable-header/
MIT License
4 stars 2 forks source link

show system message on Jenkins header #92

Closed mawinter69 closed 2 months ago

mawinter69 commented 2 months ago

move the system message inside the enabled block as it can be shown anyway only when it is enabled.

fixes: #71

image

Testing done

Manual testing

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
jonesbusy commented 2 months ago

This change cause for me instance fail to start with JCasC configuration

    appearance:
      customHeader:
        systemMessage:
          color: lightyellow
          message: "***** platform won't be available on April 27-28th 2024, all weekend"
Caused by: io.jenkins.plugins.casc.ConfigurationAsCodeBootFailure: io.jenkins.plugins.casc.ConfiguratorException: 'color' is deprecated
at io.jenkins.plugins.casc.ConfigurationAsCode.init(ConfigurationAsCode.java:343)
... 14 more
Caused by: io.jenkins.plugins.casc.ConfiguratorException: 'color' is deprecated
at io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:330)
at io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:283)

According to the plugin release notes it's not clear there is a breaking change and what to change

mawinter69 commented 2 months ago

It was actually #91 that introduced the breaking change, added the missing breaking change info there. Sorry for the inconvenience.