jenkinsci / dark-theme-plugin

Jenkins Dark Theme
https://plugins.jenkins.io/dark-theme/
MIT License
70 stars 37 forks source link

prefers-color-scheme not working in chromium #160

Closed g3n35i5 closed 3 years ago

g3n35i5 commented 3 years ago

Version report

Jenkins and plugins versions report:

Jenkins: 2.287
OS: Linux - 4.19.0-16-amd64
---
blueocean-events:1.24.5
blueocean:1.24.5
workflow-multibranch:2.23
jdk-tool:1.5
favorite:2.3.3
workflow-api:2.42
cppcheck:1.25
snakeyaml-api:1.27.0
build-timeout:1.20
git-server:1.9
blueocean-pipeline-api-impl:1.24.5
pipeline-build-step:2.13
blueocean-pipeline-editor:1.24.5
momentjs:1.1.1
pipeline-model-extensions:1.8.4
sshd:3.0.3
branch-api:2.6.3
blueocean-bitbucket-pipeline:1.24.5
plain-credentials:1.7
blueocean-github-pipeline:1.24.5
blueocean-rest-impl:1.24.5
email-ext:2.82
blueocean-commons:1.24.5
subversion:2.14.0
pubsub-light:1.13
timestamper:1.12
thinBackup:1.10
jsch:0.1.55.2
code-coverage-api:1.3.2
antisamy-markup-formatter:2.1
github-branch-source:2.10.2
blueocean-dashboard:1.24.5
blueocean-core-js:1.24.5
plot:2.1.9
maven-plugin:3.10
lockable-resources:2.10
bitbucket-push-and-pull-request:2.7.2
durable-task:1.35
apache-httpcomponents-client-4-api:4.5.13-1.0
pipeline-stage-step:2.5
mercurial:2.14
image-gallery:2.0.2
gradle:1.36
pipeline-model-api:1.8.4
workflow-aggregator:2.6
workflow-job:2.40
build-name-setter:2.1.0
authorize-project:1.4.0
jquery-detached:1.2.1
pipeline-milestone-step:1.3.2
windows-slaves:1.7
checks-api:1.7.0
htmlpublisher:1.25
git:4.7.1
pipeline-stage-tags-metadata:1.8.4
token-macro:2.15
javadoc:1.6
ssh-slaves:1.31.7
jjwt-api:0.11.2-9.c8b45b8bb173
blueocean-personalization:1.24.5
credentials:2.3.17
dtkit-api:3.0.0
blueocean-pipeline-scm-api:1.24.5
workflow-cps:2.90
folder-properties:1.2.1
blueocean-i18n:1.24.5
variant:1.4
pipeline-stage-view:2.19
htmlresource:1.02
blueocean-rest:1.24.5
plugin-util-api:2.1.0
authentication-tokens:1.4
ldap:2.5
okhttp-api:3.14.9
pam-auth:1.6
icon-shim:3.0.0
display-url-api:2.3.4
copyartifact:1.46
scm-api:2.6.4
credentials-binding:1.24
ssh-credentials:1.18.2
structs:1.22
blueocean-display-url:2.4.1
valgrind:0.28
workflow-cps-global-lib:2.18
mapdb-api:1.0.9.0
matrix-project:1.18
resource-disposer:0.15
ace-editor:1.1
sonar:2.13
workflow-basic-steps:2.23
workflow-durable-task-step:2.38
script-security:1.76
pipeline-rest-api:2.19
font-awesome-api:5.15.2-2
bootstrap4-api:4.6.0-3
jackson2-api:2.12.2
jquery3-api:3.6.0-1
docker-workflow:1.26
jaxb:2.3.0.1
docker-custom-build-environment:1.7.3
monitoring:1.87.0
pipeline-github-lib:1.0
pipeline-input-step:2.12
mailer:1.34
xunit:3.0.1
command-launcher:1.5
cobertura:1.16
data-tables-api:1.10.23-3
analysis-model-api:10.0.0
github:1.33.1
bouncycastle-api:2.20
handlebars:3.0.8
warnings-ng:9.0.1
github-api:1.123
git-client:3.7.1
sse-gateway:1.24
azure-commons:1.1.2
ws-cleanup:0.39
trilead-api:1.0.13
ant:1.11
docker-commons:1.17
workflow-step-api:2.23
cloudbees-bitbucket-branch-source:2.9.7
forensics-api:1.0.0
blueocean-config:1.24.5
azure-ad:153.v7af57b288088
blueocean-git-pipeline:1.24.5
cloudbees-folder:6.15
jira:3.2.1
role-strategy:3.1.1
pipeline-model-definition:1.8.4
cccc:0.6
matrix-auth:2.6.6
jenkins-design-language:1.24.5
pipeline-graph-analysis:1.10
popper-api:1.16.1-2
locale:1.4
workflow-scm-step:2.12
blueocean-jwt:1.24.5
junit:1.49
blueocean-web:1.24.5
blueocean-jira:1.24.5
disk-usage:0.28
workflow-support:3.8
blueocean-autofavorite:1.2.4
ansicolor:0.7.5
echarts-api:5.0.2-1
external-monitor-job:1.7
pipeline-utility-steps:2.7.1
doxygen:0.18
handy-uri-templates-2-api:2.1.8-1.0
job-dsl:1.77
theme-manager:0.6
dark-theme:0.0.12
Jenkins: Linux
Local machine: Linux

Reproduction steps

Results

Expected result:

Jenkins is in dark mode since the system setting is dark

Actual result:

Jenkins is in bright mode. When i open up jenkins in Firefox, it is in dark mode

Supposedly, Chromium should support this setting since version 76. A colleague (he uses Ubuntu instead of Archlinux) also has this problem. Is this only due to Chromium or can it also be related to this plugin?

timja commented 3 years ago

not sure, it could be that chromium doesn't support the url loading

https://github.com/jenkinsci/dark-theme-plugin/blob/master/src/main/resources/io/jenkins/plugins/darktheme/theme-system.css#L1

g3n35i5 commented 3 years ago

@timja according to https://caniuse.com/mdn-css_properties_cursor_url chromium supports that feature

timja commented 3 years ago

any errors in the browser console?

g3n35i5 commented 3 years ago

No, nothing

slackerbob commented 3 years ago

I can also confirm this bug in Chromium 92 on Arch Linux:

Version 92.0.4515.107 (Official Build) Arch Linux (64-bit)

It seems like it's a Linux-chromium-specific bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=998903

timja commented 3 years ago

Thanks, I'm going to close this as it's unrelated to this project.