jenkinsci / dark-theme-plugin

Jenkins Dark Theme
https://plugins.jenkins.io/dark-theme/
MIT License
70 stars 37 forks source link

Bootstrap colors not adjusted #427

Closed zbynek closed 11 months ago

zbynek commented 11 months ago

Jenkins and plugins versions report

Environment ```text Paste the output here ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

Open the warnings generated by Warnings NG plugin and rendered using Bootstrap 5 styles

Expected Results

Actual Results

image

Anything else?

No response

Are you interested in contributing a fix?

Yes. Not sure what's the best way to do it -- the most efficient would be to apply data-bs-theme="dark" to body when needed, and let Bootstrap figure it out. Alternatively one can add all the dark BS colors to a stylesheet in this plugin.

timja commented 11 months ago

Yes. Not sure what's the best way to do it -- the most efficient would be to apply data-bs-theme="dark" to body when needed, and let Bootstrap figure it out. Alternatively one can add all the dark BS colors to a stylesheet in this plugin.

Should be done in the bootstrap api plugin, using the theme manager API possibly with properties set in this plugin for what theme should be used.

See: https://github.com/jenkinsci/workflow-cps-plugin/pull/769