hsl instead of hsla - Githubissues

jenkinsci / dark-theme-plugin

Jenkins Dark Theme

https://plugins.jenkins.io/dark-theme/

MIT License

70 stars 37 forks source link

hsl instead of hsla #477

Closed FedericoTorselloACSoftware closed 6 months ago

FedericoTorselloACSoftware commented 6 months ago

https://github.com/jenkinsci/dark-theme-plugin/blob/808698adccaef519602c407b28cafa00103028ad/src/main/frontend/main.scss#L57

timja commented 6 months ago

Why?

FedericoTorselloACSoftware commented 6 months ago

hsl have only 3 arguments (hue, saturation, lightness) but I read 4 values. The alpha channel is present on hsla function. I hope I haven't wasted your time :D

timja commented 6 months ago

From what I can tell it is available: https://sass-lang.com/documentation/modules/#hsl

FedericoTorselloACSoftware commented 6 months ago

Very interesting, it would seem to be an elevation. I tried it on https://playcode.io/scss and this is the result:

I would like to thank you and as far as I'm concerned the issue can be closed