search

jenkinsci / dark-theme-plugin

Jenkins Dark Theme
https://plugins.jenkins.io/dark-theme/
MIT License
71 stars 37 forks source link

Remove alert styles #484

Closed janfaracik closed 4 months ago

janfaracik commented 5 months ago

With https://github.com/jenkinsci/jenkins/pull/9115 it's no longer necessary for themes to set alert style variables - so this merge request removes them.

Can either have the minimum Jenkins version be set to the weekly that contains the above MR or I can set the variables here with a comment that they can eventually be removed.

Before 9115

image

After 9115

image

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
janfaracik commented 4 months ago

Updated it to point to the latest weekly with the relevant alert style changes.