Cloudbees health plugin styles conflict with dark theme

[timja]

likely it's the bootstrap css that's loaded here: https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/blob/master/src/main/resources/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration/index.jelly#L7

cc @oleg-nenashev @aheritier

[aheritier]

Effectively @timja Not sure if the bug should be reported here or in the Health Advisor plugin. Is there any recommandation to avoid such kind of conflict between css ?

[timja]

Effectively @timja Not sure if the bug should be reported here or in the Health Advisor plugin. Is there any recommandation to avoid such kind of conflict between css ?

health advisor really as this theme just modifies the core colours with variables, but we're just aggregating issues here before reporting them out.

My suggestion would be not to use bootstrap as its invasive and doesn't quite match the rest of Jenkins styles,

The font on the Health advisor page appears to be slightly different to the rest of Jenkins, especially noticeable in the breadcrumbs but also in the sidebar.

Is there something specifically you're using bootstrap for?

cc @fqueiruga

[aheritier]

@timja honestly I don't remember, I did it many months ago. I think it was mainly for the panels. I can probably do without it but I am pretty sure that I did like often and took the example on another plugin :-) I know that there is a JEP to improve the Jenkins UI but I didn't follow it a lot. If I can get some guides about what to do / not do to be a good jenkins citizen I'll do it with pleasure cc @oleg-nenashev

[fqueiruga]

I don't see any components that make bootstrap needed. Jenkins already has .alert-* classes builtin. Removing bootstrap is always a positive :D

[aheritier]

I opened https://issues.jenkins-ci.org/browse/JENKINS-62739 to followup

[aheritier]

PR in review : https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/pull/60

[timja]

fixed by above, nice work!