jenkinsci / datadog-plugin

A Jenkins plugin used to forward metrics, events, and service checks to an account at Datadog, automatically.
https://plugins.jenkins.io/datadog/
MIT License
30 stars 48 forks source link

changed upper bound on timeout to allow for small discrepancy #348

Closed dawitgirm closed 1 year ago

dawitgirm commented 1 year ago

Requirements for Contributing to this repository

What does this PR do?

Fixes a flaky test where the upper bound of the timeout duration is exactly 11 seconds although realistically, it won't always be 11 seconds and might be slightly higher.

Description of the Change

Increase the upper bound of the timeout to 11.1 seconds, to allow for small variance of the actual pause duration.

Alternate Designs

Possible Drawbacks

The upper bound may be too lenient although I found it to be a good sweetspot.

Verification Process

Ran the test 10 times on the current master repo and passed all 10 times.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)