jenkinsci / datadog-plugin

A Jenkins plugin used to forward metrics, events, and service checks to an account at Datadog, automatically.
https://plugins.jenkins.io/datadog/
MIT License
30 stars 48 forks source link

Update order of hostname detection logic #360

Closed sarah-witt closed 1 year ago

sarah-witt commented 1 year ago

What does this PR do?

The merge of https://github.com/jenkinsci/datadog-plugin/pull/346 did not take into account the changes from https://github.com/jenkinsci/datadog-plugin/pull/345 causing build failures. This PR refactors the getAWSInstanceId to use the new HTTP client

Additionally changes the order of the hostname collection so that the AWS instance param takes precedence over the HOSTNAME variable

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)