Invalid configuration elements `emitConfigChangeEvents`

jenkinsci / datadog-plugin

A Jenkins plugin used to forward metrics, events, and service checks to an account at Datadog, automatically.

https://plugins.jenkins.io/datadog/

MIT License

34 stars 48 forks source link

Invalid configuration elements `emitConfigChangeEvents` #372

Closed smerle33 closed 1 month ago

smerle33 commented 11 months ago

Describe the bug We had an error with the upgrade from 5.5.1 to 5.6.0 : Invalid configuration elements for type class org.datadog.jenkins.plugins.datadog.DatadogGlobalConfiguration : emitConfigChangeEvents.

This property has been removed but doesn't seem to be documented

Label the issue properly.

Add bug/ label.
Add documentation label if this issue is related to documentation changes.

To Reproduce Steps to reproduce the behavior:

within the JCASC configuration under datadogGlobalConfiguration
use: emitConfigChangeEvents

Expected behavior at least information on how to replace this property and a warning of breaking change

sarah-witt commented 11 months ago

Hi @smerle thank you for reporting! Our apologies about the removal of the parameter- we will note this on the recent changelog and release a fix to not break JCASC setups. The config change events have not been sent by the plugin for a while, so for now, unsetting emitConfigChangeEvents should not have an effect on your plugin’s behavior and should resolve the error. We will push a fix that ensures that the option is deprecated rather than removed so it does not break other configurations.

sarah-witt commented 11 months ago

Hi @smerle33 we've released version 5.6.1 of the plugin which should resolve this issue. Please let me know if everything looks good on your side!

smerle33 commented 10 months ago

we have changed the configuration accordingly with 5.6.0, so we cannot confirm that the 5.6.1 takes care of the parameter declaration, but thanks for the work done !