Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix one issue at the time.
The pull request must update the test suite to demonstrate the changed functionality.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.
What does this PR do?
Fixes stack overflow on initialising DatadogTaskListenerDecorator:
BuildData instance construction is started
EnvActionImpl#getEnvironment() is called
Inside this call run's TaskListener is initialized
Once TaskListener is created, it is wrapped with DatadogTaskListenerDecorator
The decorator starts creating another BuildData instance
The EnvActionImpl#getEnvironment() call is replaced with EnvActionImpl#getOverriddenEnvironment(), which only returns the env vars that were overridden in that action.
The latter call does not trigger task listener initialisation, and allows to examine the right env vars.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.
Requirements for Contributing to this repository
What does this PR do?
Fixes stack overflow on initialising
DatadogTaskListenerDecorator:DatadogTaskListenerDecoratorThe example stack trace can be found here.
The
EnvActionImpl#getEnvironment()call is replaced withEnvActionImpl#getOverriddenEnvironment(), which only returns the env vars that were overridden in that action. The latter call does not trigger task listener initialisation, and allows to examine the right env vars.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.