Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix one issue at the time.
The pull request must update the test suite to demonstrate the changed functionality.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.
What does this PR do?
Fixes the logic that calculates queue time for pipelines and pipeline steps.
The following problems are fixed:
queue time calculated incorrectly for pipelines that first wait to start (for example, because of throttling settings) and then wait for their executor to become available. These waiting times should be summed (because the two waits happen sequentially), while the old implementations only used the biggest of the two values.
pipeline span and all of its children spans are shifted into the past, because propagated queue time is subtracted from both the start and the end timestamps (I think it used to be done this way because the plugin used DD Java Agent's API for creating spans. Pipeline span had to start before queue time, and modifying start time later was not possible)
queueing time of individual pipeline steps is counted twice: first as the queuing time, and second as part of the step itself (both durations can be seen in the pipeline trace)
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.
Requirements for Contributing to this repository
What does this PR do?
Fixes the logic that calculates queue time for pipelines and pipeline steps.
The following problems are fixed:
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.