jenkinsci / datadog-plugin

A Jenkins plugin used to forward metrics, events, and service checks to an account at Datadog, automatically.
https://plugins.jenkins.io/datadog/
MIT License
30 stars 48 forks source link

Fix BuildSpanAction deserialization logic #425

Closed nikita-tkachenko-datadog closed 3 months ago

nikita-tkachenko-datadog commented 3 months ago

Requirements for Contributing to this repository

What does this PR do?

Fixes custom deserialisation logic of the BuildSpanAction class. The version field was added to the v1 of the converter erroneously. The data written by the original converter v1 (introduced in the plugin v6.0.2) does not contain version field, so when the updated converter code tries to deserialize this field, it fails. The versioned converters are supposed to be immutable, the code was changed by mistake.

The bug was introduced in PR#387 Implement submitting in-progress pipelines data.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)