Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix one issue at the time.
The pull request must update the test suite to demonstrate the changed functionality.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.
What does this PR do?
Fixes setting Datadog APU key credential ID with Configuration-as-Code Jenkins plugin.
Description of the Change
When configuring Datadog plugin with configuration as code, targetCredentialsApiKey field is set, but not the usedApiKey which refers to the actual API key used by the plugin (could be either the credential or the API key supplied in text input).
The workaround is to check whether the used key field is initialised when the plugin attempts to read it.
If the field is not initialised, both "target" fields are checked to see if the key was supplied using one of them.
This is a temporary workaround that will be removed later when the plugin configuration is refactored to have only one field for key.
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.
Requirements for Contributing to this repository
What does this PR do?
Fixes setting Datadog APU key credential ID with Configuration-as-Code Jenkins plugin.
Description of the Change
When configuring Datadog plugin with configuration as code,
targetCredentialsApiKeyfield is set, but not theusedApiKeywhich refers to the actual API key used by the plugin (could be either the credential or the API key supplied in text input).The workaround is to check whether the used key field is initialised when the plugin attempts to read it. If the field is not initialised, both "target" fields are checked to see if the key was supplied using one of them.
This is a temporary workaround that will be removed later when the plugin configuration is refactored to have only one field for key.
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.