jenkinsci / date-parameter-plugin

Date paramter plugin for jenkins
https://plugins.jenkins.io/date-parameter/
15 stars 20 forks source link

Modernize to Jenkins 2.440.3 #18

Open sghill-rewrite opened 3 months ago

sghill-rewrite commented 3 months ago

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

I found a new SpotBugs rule started failing, so I added SuppressFBWarnings annotations to retain backwards compatibility. It would also be possible to make the public fields private, but I opted to suppress to avoid breaking changes.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Refs: sghill-rewrite/campaigns#4

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D