Readme needs updating to clarify pre-registry scan vs regular scan

jenkinsci / deepsecurity-smartcheck-plugin

Jenkins plugin that requests image scans from Deep Security Smart Check

Apache License 2.0

3 stars 2 forks source link

Readme needs updating to clarify pre-registry scan vs regular scan #1

Closed marykay25 closed 3 years ago

marykay25 commented 4 years ago

Hello,

can you rework the readme to clarify that you can do pre-registry or post registry scanning (toward the top) and then show the code needed for each? Right now it looks like this section is needed for both:

withCredentials([ usernamePassword([ credentialsId: "example-registry-auth", usernameVariable: "REGISTRY_USER", passwordVariable: "REGISTRY_PASSWORD", ])

glb commented 4 years ago

Great suggestion, thanks!